Skip to content

Dess wrd templates #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Dess wrd templates #1870

wants to merge 12 commits into from

Conversation

@dessyordanova
Copy link
Collaborator

@dessyordanova dessyordanova commented Oct 24, 2025

Report Templates in Web Report Designer: https://github.com/telerik/reporting/issues/5464

@dessyordanova dessyordanova self-assigned this Oct 24, 2025
@dessyordanova
Copy link
Collaborator Author

dessyordanova commented Oct 24, 2025

To all reviewers: Do we need a workflow diagram explaining the process for editing an existing template, considering the fact we have a dedicated tutorial how to do it?

kachamachkov
kachamachkov requested changes Oct 28, 2025
View reviewed changes
Copy link

@kachamachkov kachamachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great layout and work Desi, thank you! There are a few typos that I managed to find, please fix them. Additionally, if you like some of my refactoring suggestions, consider applying them.

yordan-mitev
yordan-mitev reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments directed at concerns related to the organization and logic of the article. I'm not commenting on any surface-level issues like tone of voice and style as I believe they must be handled after sorting out the structural matter.

@dessyordanova
Copy link
Collaborator Author

dessyordanova commented Nov 4, 2025

I have applied most of the recommendations and split the main article into two - one for end-users and one for developers as Dancho suggested:
https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/user-guide/report-templates.md
https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/knowledge-base/how-to-edit-a-report-template.md

@dessyordanova
Copy link
Collaborator Author

dessyordanova commented Nov 5, 2025

@yordan-mitev, could you please review the final version of the PR?

@dessyordanova
Copy link
Collaborator Author

dessyordanova commented Nov 5, 2025

@kachamachkov could you please check whether the requested changes are still necessary after the refactoring?

https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/user-guide/report-templates.md
https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/designing-reports/report-designer-tools/web-report-designer/configuring-report-templates.md
https://github.com/telerik/reporting-docs/blob/dess-wrd-templates/knowledge-base/how-to-edit-a-report-template.md

mzanev
mzanev approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@mzanev mzanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The articles look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzanev mzanev mzanev approved these changes

@elkinmilen elkinmilen Awaiting requested review from elkinmilen

@yordan-mitev yordan-mitev Awaiting requested review from yordan-mitev

@kachamachkov kachamachkov Awaiting requested review from kachamachkov

Requested changes must be addressed to merge this pull request.

Assignees

@dessyordanova dessyordanova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dessyordanova @yordan-mitev @mzanev @kachamachkov